Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use same protocol when forming endpoint links #18

Merged
merged 2 commits into from
Jan 17, 2024

Conversation

bodom0015
Copy link
Member

Problem

When forming links, Workbench appears to use the Kubernetes endpoint protocol (may always be HTTP)

In prod (and localdev), we should prefer HTTPS

Approach

  • fix: use the same protocol that is set on the root frontend domain when forming endpoint links

How to Test

  1. Checkout and run this branch locally (see workbench-helm-chart)
  2. Navigate to https://kubernetes.docker.internal/ (ignore browser certificate warnings)
  3. Login/register with Keycloak
    • You should be brought back to the Workbench, now logged in
  4. Add an application from the "All Apps"
    • You should be brought to "My Apps" to see your new app
  5. Launch the application
    • You should see the application turn green when it is ready
  6. Click the link to navigate to your app (ignore browser certificate warnings)
    • You should see the UI for your app load in the browser

@bodom0015 bodom0015 merged commit 1b3ef7c into develop Jan 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant