Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing unittest + mkdocs errors #1

Merged
merged 11 commits into from
Jul 9, 2024
Merged

Conversation

DomInvivo
Copy link
Collaborator

@DomInvivo DomInvivo commented Jul 9, 2024

Changelogs

  • Fixed the masking in the Attention by simply casting to bool. The mask was changed to float somewhere in TransformerEncoder call to F._canonical_mask.
  • Fixed the double VS float of the test_positional_encoders.py by simply casting the positional encoding to float. Casting is usually handled in the dataloading anyways.
  • Fixed the IPU tests by moving the IPU imports within the @pytest.mark.ipu decorator
  • Fixed the mkdocs documentation building by removing broken references
  • Upgraded the python version for the unit-test to 3.11, and removed 3.08

Simply fixing minor issues with unittests and mkdocs

@DomInvivo DomInvivo changed the base branch from main to graphium_cpp July 9, 2024 18:58
@DomInvivo DomInvivo changed the title Dom unittest Dom fixing unittest Jul 9, 2024
.github/workflows/test.yml Outdated Show resolved Hide resolved
@DomInvivo DomInvivo changed the title Dom fixing unittest Dom fixing unittest + mkdocs errors Jul 9, 2024
@DomInvivo DomInvivo changed the title Dom fixing unittest + mkdocs errors Fixing unittest + mkdocs errors Jul 9, 2024
@ndickson-nvidia ndickson-nvidia merged commit ea9a775 into graphium_cpp Jul 9, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants