-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates and refactoring #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #19 +/- ##
===========================================
+ Coverage 22.16% 60.53% +38.37%
===========================================
Files 1 1
Lines 379 484 +105
===========================================
+ Hits 84 293 +209
+ Misses 292 159 -133
- Partials 3 32 +29 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring and Error Handling:
cmd/run.go
: Replaced the deprecatedgolang.org/x/net/context
with the standard librarycontext
package. Added anos.Exit(1)
call to handle errors more gracefully.internal/ballot/ballot.go
: Refactored theCommand
method toCommandContext
to support context cancellation. Improved error handling and added validation checks for required fields in theBallot
Configuration Updates:
configs/consul_with_3_nodes/
: Removed old JSON configuration files for Consul agents and replaced them with new HCL configuration files.configs/development/
: Renamed and updated Dockerfile and Makefile to reflect the new development environment structure.configs/development/docker-compose.yaml
: Updated the Docker Compose file to enable script checks and client settings for Consul agents. Removed the custom network configuration.Consistency Improvements:
configs/development/ballot-1/ballot.yaml
,configs/development/ballot-2/ballot.yaml
,configs/development/ballot-3/ballot.yaml
: Standardized service IDs and names to use hyphens instead of underscores.These changes enhance the project's maintainability, error handling, and configuration consistency.