Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicated attributes for Xenium and CosMX #405

Merged
merged 1 commit into from
May 9, 2024
Merged

Remove duplicated attributes for Xenium and CosMX #405

merged 1 commit into from
May 9, 2024

Conversation

adamjtaylor
Copy link
Contributor

Closes #403

@adamjtaylor adamjtaylor linked an issue May 9, 2024 that may be closed by this pull request
Model integrity failure: Check all attributes are unique #403
Closed
@adamjtaylor adamjtaylor requested a review from aditigopalan May 9, 2024 14:34
@adamjtaylor
Copy link
Contributor Author

Integrity checks now pass. OK to merge once JSON-LD generation has completed

@adamjtaylor
Copy link
Contributor Author

Ah... of course the duplicates in the CSV would have been eliminated by Schematic so no JSON-LD changes to commit

@aditigopalan aditigopalan merged commit f4a2b7f into main May 9, 2024
7 checks passed
@aditigopalan aditigopalan deleted the 403-model-integrity-failure-check-all-attributes-are-unique branch May 9, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aditigopalan aditigopalan aditigopalan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Model integrity failure: Check all attributes are unique
2 participants
@adamjtaylor @aditigopalan