381-fix-hic #404
381-fix-hic #404
Conversation
|
@adamjtaylor looks like that last PR came from my fork. All fixed for now! |
There was a problem hiding this comment.
Sorry... looking back at the RFC doc there are some more changes required
HTAN.model.csv
Outdated
| @@ -155,7 +155,7 @@ Ligation Condition,Name of ligase and condition for proximity ligation,,,,TRUE,S | |||
| Biotin Enrichment,Whether biotin is used for enriching ligation product,"Yes, No",,,TRUE,Sequencing,,, | |||
| DNA Input Amount,"Amount of DNA for library construction, in nanograms.",,,,TRUE,Sequencing,,,int | |||
| Resolution,"Binning size used for generating contact matrix, in basepair.",,,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,,list::-?\d+ | |||
| Loop Window,Binning size used for calling significant dot interactions (loops),,,,TRUE,Sequencing,,,int | |||
There was a problem hiding this comment.
Validation rule for Loop Window should be list like :: regex search -?\d+
HTAN.model.csv
Outdated
| @@ -155,7 +155,7 @@ Ligation Condition,Name of ligase and condition for proximity ligation,,,,TRUE,S | |||
| Biotin Enrichment,Whether biotin is used for enriching ligation product,"Yes, No",,,TRUE,Sequencing,,, | |||
| DNA Input Amount,"Amount of DNA for library construction, in nanograms.",,,,TRUE,Sequencing,,,int | |||
| Resolution,"Binning size used for generating contact matrix, in basepair.",,,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,,list::-?\d+ | |||
| Loop Window,Binning size used for calling significant dot interactions (loops),,,,TRUE,Sequencing,,,int | |||
| Stripe Window,"Binning size used for calling significant architectural stripes. Can be an integer or int/int, indicating bin size and sliding window size if different.","HiCCUPS, Cooltools, Other",,,TRUE,Sequencing,,, | |||
There was a problem hiding this comment.
Change Stripe Window Description this to say
Binning size used for calling significant architectural stripes. Can be an integer or comma-separated list of integers indicating bin size and sliding window size if different.
There was a problem hiding this comment.
The valid values here don't seem to be in the right attribute. Remove valid values from Stripe Window
There was a problem hiding this comment.
Valdation rule for Stripe Window should be list like :: regex search -?\d+
HTAN.model.csv
Outdated
| @@ -155,7 +155,7 @@ Ligation Condition,Name of ligase and condition for proximity ligation,,,,TRUE,S | |||
| Biotin Enrichment,Whether biotin is used for enriching ligation product,"Yes, No",,,TRUE,Sequencing,,, | |||
| DNA Input Amount,"Amount of DNA for library construction, in nanograms.",,,,TRUE,Sequencing,,,int | |||
| Resolution,"Binning size used for generating contact matrix, in basepair.",,,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,, | |||
| Stripe Calling,"Tool used for identifying architectural stripe-forming, interaction hotspots.","MACS2, Other",,,TRUE,Sequencing,,,list::-?\d+ | |||
| Loop Window,Binning size used for calling significant dot interactions (loops),,,,TRUE,Sequencing,,,int | |||
| Stripe Window,"Binning size used for calling significant architectural stripes. Can be an integer or int/int, indicating bin size and sliding window size if different.","HiCCUPS, Cooltools, Other",,,TRUE,Sequencing,,, | |||
| Loop Calling,Tool used for identifying loop interactions,,,,TRUE,Sequencing,,, | |||
There was a problem hiding this comment.
Valid values for Loop Calling should be HiCCUPS, Cooltools, Other
|
@aditigopalan not urgent but just checking if you had any questions about the requested changes. |
Not at the moment! |
Updating Loop & Stripe Window
…into fix-381-hic
Fixes #381