Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

381-fix #395

Closed
wants to merge 1 commit into from
Closed

381-fix #395

wants to merge 1 commit into from

Conversation

aditigopalan
Copy link
Contributor

Adding bedpe as a file format, fixing validation rules for stripe window and loop window

Adding bedpe as a file format, fixing validation rules for stripe window and loop window
@aditigopalan
Copy link
Contributor Author

@adamjtaylor the regex I used for loop window is list::-?\d+ . Let me know if that and everything else works!

@adamjtaylor
Copy link
Contributor

Humm... actions change with a weird git error about your data-models-docs branch

Run r-lib/actions/pr-push@v2
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
[@octokit/rest] `const Octokit = require("@octokit/rest")` is deprecated. Use `const { Octokit } = require("@octokit/rest")` instead
Collecting information about PR #395...
git push ***github.com/aditigopalan/data-models-docs.git -q HEAD:381-hic
remote: Permission to aditigopalan/data-models-docs.git denied to github-actions[bot].
fatal: unable to access 'https://github.com/aditigopalan/data-models-docs.git/': The requested URL returned error: 403
Error: The process 'git' failed with exit code 128

@adamjtaylor
Copy link
Contributor

It also looks like this version reverts some changes from before our recent data model release.

Copy link
Contributor

@adamjtaylor adamjtaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JSON-LD conversion failed plus some issues with recent data model changes being reverted. Happy to discuss

@@ -84,7 +84,7 @@ Visium File Type,The file type generated for the visium experiment.,"reference p
Run ID,A unique identifier for this individual run (typically associated with a single slide) of the spatial transcriptomic processing workflow.,,,,TRUE,Spatial Transcriptomics,,,
Capture Area,"Area (or Capture Area) - One of the either four or two active regions where tissue can be placed on a Visium slide. Each area is intended to contain only one tissue sample. Slide areas are named consecutively from top to bottom: A1, B1, C1, D1 for Visium slides with 6.5 mm Capture Area and A, B for CytAssist slides with 11 mm Capture Area. Both CytAssist slides with 6.5 mm Capture Area and Gateway Slides contain only two slide areas, A1 and D1.","A, B, C, D, A1, B1, C1, D1",,,FALSE,Spatial Transcriptomics,,,
Slide Version,Version of imaging slide used. Slide version is critical for the analysis of the sequencing data as different slides have different capture area layouts.,"V1, V2, V3, V4",,,FALSE,Spatial Transcriptomics,,,
Slide ID,"For Visium, it is the unique identifier printed on the label of each Visium slide. The serial number starts with V followed by a number which can range between one through five and ends with a dash and a three digit number, such as 123. For CosMx, this refers to the loaded Flow Cell ID. For Xenium, this ID indicates the slide orientation, as it matches the relative location of the ID on the physical Xenium slide.",,,,FALSE,Spatial Transcriptomics,,,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we are reverting to older changes here. Make sure branch up to date with main

@aditigopalan aditigopalan marked this pull request as draft May 9, 2024 12:38
@aditigopalan aditigopalan closed this by deleting the head repository May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants