Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Model Updates for CosMx RFC #379

Merged
merged 16 commits into from
Apr 29, 2024
Merged

Conversation

PozhidayevaDarya
Copy link
Contributor

RFC document is in progress and can be found here:
https://docs.google.com/document/d/1cQ035OUx5CLFfJdQiJdotggpLyjg6a8KOycbsCH6MHw/edit#heading=h.onb0ee2qamgt

Issue for this PR can be found here:
#370

Note: CosMx will need to be added to the model first, then Xenium. This is because there are some redundant variables.
The current status of these items is subject to change.

@adamjtaylor
Copy link
Contributor

Thank you @PozhidayevaDarya! Currently failing checks in two places

First

"Surface Area" used in component "Nanostring CosMx SMI Experiment" is not defined in the data model
"Percent Total Transcripts within Cells" used in component "Nanostring CosMx SMI Experiment" is not defined in the data model

Second

"Percent of Transcripts within Cells" is is not used by any component

HTAN.model.csv Outdated Show resolved Hide resolved
@adamjtaylor adamjtaylor merged commit ed898f6 into main Apr 29, 2024
@adamjtaylor adamjtaylor deleted the data-model-updates-for-CosMx-RFC branch April 29, 2024 15:43
@adamjtaylor adamjtaylor linked an issue Apr 29, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement draft CosMX RFC in data model
2 participants