Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hi-C level 3 fixes #381

Closed
3 tasks done
adamjtaylor opened this issue Apr 13, 2024 · 5 comments · Fixed by #404
Closed
3 tasks done

Hi-C level 3 fixes #381

adamjtaylor opened this issue Apr 13, 2024 · 5 comments · Fixed by #404
Assignees
Labels

Comments

@adamjtaylor
Copy link
Contributor

adamjtaylor commented Apr 13, 2024

See HTAN-414

  • Add bedpe file format to File Format
  • Names+descriptions and allowed values of Loop Window and Stripe Window are inverted.
  • Change validation rule for loop window to list int (confirm correct form of this rule in schematic docs first)
@aclayton555
Copy link
Contributor

@adamjtaylor and @aditigopalan I'm wondering whether we can add this one to our current 24-4 sprint? If so, Aditi, is this something I can assign to you?

@aclayton555
Copy link
Contributor

aclayton555 commented Apr 29, 2024

Continue this into 24-5 sprint. For third item, consider doing a huge string or a regex. Also inquire if list int is on the roadmap for validation rules (if not, please file a request for this for the FAIR backlog)

@aclayton555
Copy link
Contributor

@aditigopalan are we on track to complete this before our 24-5 HTAN Data Model wrap up on May 30?

@aditigopalan
Copy link
Contributor

@aditigopalan are we on track to complete this before our 24-5 HTAN Data Model wrap up on May 30?

yes, pending review

@aclayton555
Copy link
Contributor

aclayton555 commented May 30, 2024

24-5 Data Model Sprint Wrap-Up: Adam and Aditi will work on this further offline (some Github weirdness going on)

If we can complete these changes, we will aim to include this in our next release planned for the first week of June.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants