Use correct channel ID in WaitForFundingSigned #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The commit message needs to be fixed: it only has a title (I guess you forgot to copy+paste the description from the PR into it?). Also now that you're gonna change the commit message, please add a link to the commit in official DNL that is the same as this one. |
This makes geewallet's OutgoingUnfundedChannel report the correct/true channel id, rather than the temporary channel id used during the initial stage of channel opening. This is commit 6f1175a in upstream DNL.
canndrew
force-pushed
the
nblockchain-master-wait-for-funding-signed-channel-id-fix
branch
from
3e48d7b
to
fda35ef
Compare
|
Fixed. |
knocte
force-pushed
the
master
branch
6 times, most recently
from
135c9bb
to
02564ea
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
dd99cda
to
08262fb
Compare
knocte
force-pushed
the
master
branch
12 times, most recently
from
506fef6
to
bb0ecb4
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
f9839d5
to
6281acc
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
9f9f73e
to
2883c78
Compare
canndrew
force-pushed
the
master
branch
4 times, most recently
from
f817da9
to
0340b0b
Compare
knocte
force-pushed
the
master
branch
3 times, most recently
from
0389f6a
to
60d2401
Compare
knocte
force-pushed
the
master
branch
4 times, most recently
from
419cd8d
to
f0461b4
Compare
knocte
force-pushed
the
master
branch
4 times, most recently
from
37fe5af
to
1f418fe
Compare
knocte
force-pushed
the
master
branch
5 times, most recently
from
bd34034
to
b67e13f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes geewallet's
OutgoingUnfundedChannelreport the correct/true channel id, rather than the temporary channel id used during the initial stage of channel opening.