Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Refactor:GTK: switch to GTK3 #1008

Open
wants to merge 7 commits into
base: trunk
Choose a base branch
from
Open

WIP: Refactor:GTK: switch to GTK3 #1008

wants to merge 7 commits into from

Conversation

okias
Copy link
Contributor

@okias okias commented May 21, 2020

Compiles, open window and also shows menu with some warnings.

@metalstrolch
Copy link
Contributor

Continued this a little bit: Porting the now missing expose_event callback to the newer draw callback fixes the crash and allows drawing. Refactor some deprecated things and add mouse wheel to event list.

Now draws using gtk3. Menu unchecked and still compiling with warnings.

@metalstrolch metalstrolch added the gtk Related to the GTK-based GUI label Jun 21, 2020
@metalstrolch
Copy link
Contributor

OK, somehow the GUI shows up now. But a lot of it seems not to work. It quite often segfaults.
A lot of deprecation warnings during build.
Will leave this alone for some time.

okias and others added 5 commits May 22, 2021 12:55
Compiles and open GTK 3 window.

Closes: navit-gps#804
Now it seems to somehow work. It draws and the usual controls (keyboard,
mouse, mousewheeel) seem to work.

Memory usage unchecked. Need to valgrind.
@okias
Copy link
Contributor Author

okias commented May 22, 2021

rebased a top of current git and didn't crashed yet.

EDIT: also tested on Mobian + wayland based Phosh (phone OnePlus 6T), also somehow work. I'll try -Werror for GTK subsystem.

@metalstrolch
Copy link
Contributor

Glad to see somebody finally continues this. Concentrate on the build warnings first. The segfaults may be connected to the warnings.

@okias
Copy link
Contributor Author

okias commented May 22, 2021

more I looking at it, it look to me it would make sense to do complete rewrite [1] to GTK 3 (or directly to GTK 4, since devices and phones can benefit from 3D accelerated view).

[1] rewrite I mean redesign the interface again, not just migrate from GTK 2 to 3.

With my current pace and inability to get even maps in compatible format [http://maps9.navit-project.org/ doesn't work for me], I'm kinda losing hope I'll be able to do the whole job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gtk Related to the GTK-based GUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants