Publiser meldinger med Kafka-key i API-app #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Nov 20, 2024
| @@ -25,6 +25,7 @@ class HentForespoerslerProducer( | |||
| ) { | |||
| rapid | |||
| .publish( | |||
| key = UUID.randomUUID(), | |||
There was a problem hiding this comment.
Her har vi ingen naturlig nøkkel, men vi det er heller ikke så farlig når vi kun skal lese data.
bjerga
commented
Nov 20, 2024
| @@ -253,7 +253,7 @@ abstract class EndToEndTest : ContainerTest() { | |||
|
|
|||
| fun publish(vararg messageFields: Pair<Key, JsonElement>) { | |||
| println("Publiserer melding med felt: ${messageFields.toMap()}") | |||
| imTestRapid.publish(messageFields.toMap()) | |||
| imTestRapid.publish(UUID.randomUUID(), *messageFields) | |||
There was a problem hiding this comment.
Nøkkelen har ikke betydning her, da imTestRapid ikke er en ekte rapid.
|
Testet OK. |
b162214
reviewed
Nov 21, 2024
api/src/main/kotlin/no/nav/helsearbeidsgiver/inntektsmelding/api/auth/TilgangProducer.kt
Show resolved
Hide resolved
b162214
approved these changes
Nov 21, 2024
| @@ -15,6 +15,7 @@ import no.nav.helsearbeidsgiver.utils.log.MdcUtils | |||
| import no.nav.helsearbeidsgiver.utils.wrapper.Fnr | |||
| import java.util.UUID | |||
|
|
|||
| // TODO test | |||
There was a problem hiding this comment.
Tok den med som en påminnelse til fremtiden når jeg tilfeldigvis så at den klassen manglet tester.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dette er nødvendig for å sikre oss at meldingene på Kafka blir lest i samme rekkefølge som de blir skrevet.