Fjern unødvendig behov brukt under lagring av ekstern IM #734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Oct 29, 2024
| @@ -91,7 +90,7 @@ class LagreEksternImRiverTest : | |||
| context("ignorerer melding") { | |||
| withData( | |||
| mapOf( | |||
| "melding med uønsket behov" to Pair(Key.BEHOV, BehovType.HENT_VIRKSOMHET_NAVN.toJson()), | |||
| // "melding med uønsket behov" to Pair(Key.BEHOV, BehovType.HENT_VIRKSOMHET_NAVN.toJson()), | |||
There was a problem hiding this comment.
Skal kommenteres inn igjen ganske snart.
There was a problem hiding this comment.
Per nå så tillater vi vilkårlige behov, men det gjør vi kun i en overgangsfase, ref. https://github.com/navikt/helsearbeidsgiver-inntektsmelding/pull/734/files#diff-a2838e484f753e890c08a72b3bad94c722036ac85d157f0463555b968dcd9c9bR35.
bjerga
commented
Oct 29, 2024
| bestemmendeFravaersdag = Key.BESTEMMENDE_FRAVAERSDAG.lesOrNull(LocalDateSerializer, json), | ||
| journalpostId = Key.JOURNALPOST_ID.les(String.serializer(), json), | ||
| ) | ||
| } |
There was a problem hiding this comment.
Smyger med denne endringen, som forbereder fjerning av enda et behov som kun brukes i den asynke flyten.
|
Testet OK. |
magnusae
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vi trenger ikke behov i rivers som kun er med i en asynkron flyt.