Legg til ny river for å hente arbeidsforhold #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Testet OK. |
b162214
reviewed
Jul 29, 2024
| @@ -46,7 +46,7 @@ class ArbeidsforholdLoeser( | |||
| override fun accept(): River.PacketValidation = | |||
| River.PacketValidation { | |||
| it.demandValues( | |||
| Key.BEHOV to BehovType.ARBEIDSFORHOLD.name, | |||
| Key.BEHOV to BehovType.HENT_ARBEIDSFORHOLD.name, | |||
There was a problem hiding this comment.
Betyr dette at både ArbeidsforholdLoeser og HentArbeidsforholdRiver løser de samme behovene samtidig? så førstemann som får svar blir brukt.
There was a problem hiding this comment.
Nei, fordi den ene krever at noen av verdiene ligger på rot, mens den andre krever at de ligger nested inni Key.DATA.
b162214
approved these changes
Jul 29, 2024
| Key.EVENT_NAME to eventName.toJson(), | ||
| Key.UUID to transaksjonId.toJson(), | ||
| Key.DATA to | ||
| data |
There was a problem hiding this comment.
Har ikke tenkt på dete før, men blir allt som er i data feltet som kommer inn til riveren sendt med videre her?
There was a problem hiding this comment.
Det stemmer. Det er sånn "state" blir bevart i de stateless servicene.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.