Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Støtt ny skjemaklasse #619

Merged
merged 3 commits into from
Jul 25, 2024
Merged

Støtt ny skjemaklasse #619

merged 3 commits into from
Jul 25, 2024

Conversation

bjerga
Copy link
Contributor

@bjerga bjerga commented Jul 18, 2024

Vi ønsker å bytte fra Innsending til SkjemaInntektsmelding. Denne endringen gjør at vi kan lese begge klasser, slik at frontend kan bytte uten at backend tryner.

@bjerga bjerga requested a review from a team as a code owner July 18, 2024 12:45
runCatching {
json.fromJson(SkjemaInntektsmelding.serializer()).convert(
sykmeldingsperioder = emptyList(),
aarsakInnsending = AarsakInnsending.Ny,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prøver å forstå dette. Når er det egentlig AarsakInnsending blir til Endring her?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aldri! Jeg hadde glemt at det var noe som manglet, men når du sier det så må det et steg til for å sjekke om vi har noe i databasen for å bestemme om det er endring eller ei. Godt du er på!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Greit å verifisere i backend sikkert. Men er det mulig å se i payloaden fra frontend at det er endring?
Må man ikke gi en begrunnelse for endring etc.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Det feltet blir bestemt av om man sender fra en kvitteringsside eller ei, så brukeren bestemmer ikke noe over feltet. Begrunnelse for endring er for inntekt.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bjerga
Copy link
Contributor Author

bjerga commented Jul 24, 2024

Testet OK med gammelt format.

@bjerga bjerga merged commit ad3b9c7 into main Jul 25, 2024
19 checks passed
@bjerga bjerga deleted the dev/overgang-nytt-skjema branch July 25, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants