-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Støtt ny skjemaklasse #619
Conversation
runCatching { | ||
json.fromJson(SkjemaInntektsmelding.serializer()).convert( | ||
sykmeldingsperioder = emptyList(), | ||
aarsakInnsending = AarsakInnsending.Ny, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Prøver å forstå dette. Når er det egentlig AarsakInnsending blir til Endring her?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aldri! Jeg hadde glemt at det var noe som manglet, men når du sier det så må det et steg til for å sjekke om vi har noe i databasen for å bestemme om det er endring eller ei. Godt du er på!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Greit å verifisere i backend sikkert. Men er det mulig å se i payloaden fra frontend at det er endring?
Må man ikke gi en begrunnelse for endring etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Det feltet blir bestemt av om man sender fra en kvitteringsside eller ei, så brukeren bestemmer ikke noe over feltet. Begrunnelse for endring er for inntekt.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nå har jeg fikset det. I starten setter man AarsakInnsendig.Ny
uansett, men så endres det i https://github.com/navikt/helsearbeidsgiver-inntektsmelding/pull/619/files#diff-a305504fd5988ecbc6a069c88045df4d7077a7966c13974403ae8aea298d2a89R191.
Testet OK med gammelt format. |
Vi ønsker å bytte fra
Innsending
tilSkjemaInntektsmelding
. Denne endringen gjør at vi kan lese begge klasser, slik at frontend kan bytte uten at backend tryner.