Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Legg til flere tester for lagring av selvbestemt IM #579

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

bjerga
Copy link
Contributor

@bjerga bjerga commented Jun 26, 2024

No description provided.

@bjerga bjerga requested a review from a team as a code owner June 26, 2024 08:35
Comment on lines -58 to -60
MdcUtils.withLogFields(
Log.transaksjonId(transaksjonId)
) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fjernet denne. Loggfeltet blir allerede lagt til et par linjer lengre opp.

val actualJson = response.bodyAsText()

response.status shouldBe HttpStatusCode.InternalServerError
actualJson shouldBe "\"Error 500: no.nav.helsearbeidsgiver.inntektsmelding.api.auth.ManglerAltinnRettigheterException\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Burde ikke denne egentlig vært forbidden?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja, det gir mening, men da burde vi kanskje ha det slik for alle kall som feiler tilgangssjekken?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ja det burde vel være likt.
Trodde vi hadde 403 på forespurt inntektsmelding.
Men det er vel forskjellig i selvbestemt tydeligvis.

@bjerga bjerga merged commit 09d072a into main Jun 27, 2024
15 checks passed
@bjerga bjerga deleted the sb-lagre-flere-tester branch June 27, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants