Fjern overflødige felt fra refusjon #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjerga
commented
Oct 9, 2023
Comment on lines
-46
to
+55
| // TODO gjør denne sjekken ved opprettelse | ||
| if (it.fullLønnIArbeidsgiverPerioden?.utbetalerFullLønn == true) { | ||
| it.copy( | ||
| fullLønnIArbeidsgiverPerioden = FullLonnIArbeidsgiverPerioden( | ||
| utbetalerFullLønn = true, | ||
| begrunnelse = null, | ||
| utbetalt = null | ||
| val request = Jackson.fromJson<InnsendingRequest>(call.receiveText()) | ||
| .let { | ||
| // TODO gjør denne sjekken ved opprettelse | ||
| if (it.fullLønnIArbeidsgiverPerioden?.utbetalerFullLønn == true) { | ||
| it.copy( | ||
| fullLønnIArbeidsgiverPerioden = FullLonnIArbeidsgiverPerioden( | ||
| utbetalerFullLønn = true, | ||
| begrunnelse = null, | ||
| utbetalt = null | ||
| ) |
There was a problem hiding this comment.
Endret bare indent. Trodde dette skulle vises bedre -.-
| @@ -117,6 +126,91 @@ class InnsendingRouteKtTest : ApiTest() { | |||
| assertEquals(InnsendingResponse(Mock.forespoerselId).toJsonStr(InnsendingResponse.serializer()), response.bodyAsText()) | |||
| } | |||
|
|
|||
| @Test | |||
| fun `fjern ugyldige verdier ved utbetaling av full lønn i arbeisdgiverperioden`() = testApi { | |||
There was a problem hiding this comment.
Denne tester ikke endringen fra denne commiten, men testen mangla og var lik den andre, så da hev jeg den med.
mortenbyhring
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.