Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Add case which set default threshold #797

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

cheesecrust
Copy link

๐Ÿ”— Related Issue

โŒจ๏ธ What I did

  • lqdetect threshold ์ง€์ •์‹œ default threshold๋กœ ์ง€์ •๋˜๋Š” ๊ฒฝ์šฐ๋ฅผ ์ถ”๊ฐ€ํ•˜์˜€์Šต๋‹ˆ๋‹ค.

Copy link
Collaborator

@jhpark816 jhpark816 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๋ฆฌ๋ทฐ ์™„๋ฃŒ

@@ -895,7 +895,7 @@ lqdetect show\r\n
lqdetect stats\r\n
```

\<detect_threshold\>๋Š” long query๋กœ ๋ถ„๋ฅ˜ํ•˜๋Š” ๊ธฐ์ค€์œผ๋กœ ํ•ด๋‹น ์š”์ฒญ์—์„œ ์ ‘๊ทผํ•˜๋Š” elements ์ˆ˜๋กœ ๋‚˜ํƒ€๋‚ด๋ฉฐ, ์–ด๋–ค ์š”์ฒญ์—์„œ ์ฃผ์–ด์ง„ threshold ์ด์ƒ์œผ๋กœ ๋งŽ์€ elements๋ฅผ ์ ‘๊ทผํ•˜๋Š” ์š”์ฒญ์„ long query๋กœ ๊ตฌ๋ถ„ํ•œ๋‹ค. ์ƒ๋žต ์‹œ default threshold๋Š” 4000์ด๋‹ค.
\<detect_threshold\>๋Š” long query๋กœ ๋ถ„๋ฅ˜ํ•˜๋Š” ๊ธฐ์ค€์œผ๋กœ ํ•ด๋‹น ์š”์ฒญ์—์„œ ์ ‘๊ทผํ•˜๋Š” elements ์ˆ˜๋กœ ๋‚˜ํƒ€๋‚ด๋ฉฐ, ์–ด๋–ค ์š”์ฒญ์—์„œ ์ฃผ์–ด์ง„ threshold ์ด์ƒ์œผ๋กœ ๋งŽ์€ elements๋ฅผ ์ ‘๊ทผํ•˜๋Š” ์š”์ฒญ์„ long query๋กœ ๊ตฌ๋ถ„ํ•œ๋‹ค. 0์œผ๋กœ ์ง€์ •ํ•˜๊ฑฐ๋‚˜ ์ƒ๋žต ์‹œ default threshold 4000์œผ๋กœ ์ง€์ •๋ฉ๋‹ˆ๋‹ค.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default threshold 4000 => default threshold๋Š” 4000

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message๋Š” ์•„๋ž˜์™€ ๊ฐ™์ด ์ˆ˜์ •ํ•ฉ์‹œ๋‹ค.

DOC: Updated the default threshold setting of long query detect.

@jhpark816 jhpark816 merged commit 803a30e into naver:develop Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants