Added new contributors list

[mxaddict]

closes #348
build: https://deploy-preview-352--cranky-visvesvaraya-877402.netlify.app/developers

[mxaddict]

[mxaddict]

@proletesseract @anquii
You can check the build here: https://deploy-preview-352--cranky-visvesvaraya-877402.netlify.app/developers

[proletesseract]

looks good to me, my one question would be that I don't recognize some of the top contributors? Are they people who committed to repos before we forked from them? should they be included, or should we filter them out some how?

[proletesseract]

@mxaddict please comment your address for bounty payment and I will send you the reward.

[mxaddict]

NRXfZ1egFxMSUsc4Ufpi4Lm7DdXStYmeBG Same one that I use for core.

…

On Tue, Mar 8, 2022, 13:16 Craig M. ***@***.***> wrote: @mxaddict <https://github.com/mxaddict> please comment your address for bounty payment and I will send you the reward. — Reply to this email directly, view it on GitHub <#352 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAIDAKLP5LJHQJVGE63RZZDU63PBFANCNFSM5MV7NHGQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[mxaddict]

@anquii if you have any ideas on how to make this UI look better, let me know.

[anquii]

@anquii if you have any ideas on how to make this UI look better, let me know.

1. if i remember correctly from our chat on discord, @proletesseract had the idea of having the cta show "Show [number_of_additional_repos] more" (e.g. "Show 2 more"). i think that could be a nice addition

2. when u click "Show more" on someone with many repos (e.g. "aguycalled"), the spacing between the "profile" picture and the name increases quite a bit.. there's no reason for that spacing to increase (makes it look a bit weird as well), so would be good if that could be fixed

3. it'd be great if u could add a bit of lightness to the current color profile, so that it becomes easier to see the dark text within the boxes

[anquii]

looks good to me, my one question would be that I don't recognize some of the top contributors? Are they people who committed to repos before we forked from them? should they be included, or should we filter them out some how?

should filter them out imo

[mxaddict]

looks good to me, my one question would be that I don't recognize some of the top contributors? Are they people who committed to repos before we forked from them? should they be included, or should we filter them out some how?

should filter them out imo

I don't think that's fair, we should either not show those repos in the list, or show all the contributors

I think that filtering them to only show our community is a form of bias/censorship

What do you guys think @aguycalled @chasingkirkjufell @proletesseract ?

[mxaddict]

@anquii if you have any ideas on how to make this UI look better, let me know.

1. if i remember correctly from our chat on discord, @proletesseract had the idea of having the cta show "Show [number_of_additional_repos] more" (e.g. "Show 2 more"). i think that could be a nice addition
2. when u click "Show more" on someone with many repos (e.g. "aguycalled"), the spacing between the "profile" picture and the name increases quite a bit.. there's no reason for that spacing to increase (makes it look a bit weird as well), so would be good if that could be fixed
3. it'd be great if u could add a bit of lightness to the current color profile, so that it becomes easier to see the dark text within the boxes

Makes, sense I'll post back when I've done these.

[proletesseract]

i understand the censorship argument, but i also wonder if it is a misleading to include someone who only contributed before we forked their repo? it could be mis understood they are working on our fork? Perhaps one solution would be to filter them out of the contributors list and have a list of "acknowledgements" to show these people so they are not confused as navcoin developers. I don't know... i think that is out of scope of this ticket either way. I will leave it up to you to make the decision to leave them in or filter pre-fork contributions based on your judgement and the input of others.

[aguycalled]

I'd filter the contributors from upstream

[mxaddict]

Alright, I think I like the idea of having a section for contributions that came pre-fork, maybe a simple list bellow the contributors list.

[proletesseract]

@mxaddict

the bounty has been paid. I will leave it to your judgement and discussions on when to merge this feature but as far as i am concerned you delivered what was asked already and then some.

Thank you :)