Added is_mine property to listtokens return value if token balance is…

[mxaddict]

closes #923

[aguycalled]

i think what sakdeniz meant with this request was to filter the entries which are owned by the wallet (independently of the balance). you can check the logic at the minttoken or mintnft rpc commands to see how to check if a token is owned (line 1622 rpcwallet.cpp for example)

[mxaddict]

I see, should the (mine) param for listtokens be updated as well? Cause that shows tokens that have balance, but might not be owned by the wallet.

[aguycalled]

yes probably, those tokens can easily be filtered without the current mine just checking for balance > 0 client side

[mxaddict]

yes probably, those tokens can easily be filtered without the current mine just checking for balance > 0 client side

Alright

[mxaddict]

@aguycalled I've updated the logic, does this look good?

[aguycalled]

i would need to test it, but initially it looks to me like it would label as mine tokens which are not owned by the wallet

[navbuilder]

A new build of 8ead11a has completed succesfully!
Binaries available at https://build.nav.community/binaries/add-is-mine-to-listtokens-rpc-command

[navbuilder]

A new build of 2d7e434 has completed succesfully!
Binaries available at https://build.nav.community/binaries/add-is-mine-to-listtokens-rpc-command

[mxaddict]

@aguycalled this seems to be working with my testing but @sakdeniz said he was having issues, I'm still trying to investigate.

@sakdeniz could you let me know what steps you took so I can replicate your issue with this.

[aguycalled]

from what I read in the code

             // Is this token ours?
             bool fTokenIsMine = true;

isMine is by default yes

             if (!pwalletMain->HaveBLSCTTokenKey(it->second.key))
             {

this block runs only if the wallet does not have the key for the token

                 if (pk.GetG1Element() != it->second.key)
                     fTokenIsMine = false;

wallet compares the stored key with the assigned to the token.

in my opinion it should be false by default and set it to true if the stored key equals the assigned to the token

but giving this opinion just from reading the code

[mxaddict]

Does this code return true even if the spend key does not own the token/nft?

pwalletMain->HaveBLSCTTokenKey(it->second.key)

[mxaddict]

If it returns true when spendkey does not own the token or nft, I think we will need to update the logic in mintnft and minttoken as well.

[mxaddict]

@aguycalled this seems to be working with my testing but @sakdeniz said he was having issues, I'm still trying to investigate.

@sakdeniz could you let me know what steps you took so I can replicate your issue with this.

@sakdeniz I think you might have been running the first build (Which was only checking balance)

[navbuilder]

A new build of a9cafef has completed succesfully!
Binaries available at https://build.nav.community/binaries/add-is-mine-to-listtokens-rpc-command

[chasingkirkjufell]

tested gitian build on windows 10

[chasingkirkjufell]

just wondering, why not add a filter for the rpc instead? like listtokens mine wouldn't that be more straight forward and the output will be clean instead of trying to go through all of them and find the one has is_mine: true

[sakdeniz]

Tested with latest build, and it works fine.

[navbuilder]

A new build of fb3804b has completed succesfully!
Binaries available at https://build.nav.community/binaries/add-is-mine-to-listtokens-rpc-command