Skip to content

Commit

Permalink
Merge bitcoin#29172: fuzz: set nMaxOutboundLimit in connman target
Browse files Browse the repository at this point in the history
e5b9ee0 fuzz: set `nMaxOutboundLimit` in connman target (brunoerg)

Pull request description:

  Setting `nMaxOutboundLimit` (`-maxuploadtarget`) will make fuzz to reach more coverage in connman target. This value is used in `GetMaxOutboundTimeLeftInCycle`, `OutboundTargetReached` and `GetOutboundTargetBytesLeft`.

ACKs for top commit:
  dergoegge:
    utACK e5b9ee0
  jonatack:
    ACK e5b9ee0

Tree-SHA512: d19c83602b0a487e6da0e3be539aa2abc95b8bbf36cf9a3e391a4af53b959f68ca38548a96d27d56742e3b772f648da04e2bf8973dfc0ab1cdabf4f2e8d44de6
  • Loading branch information
fanquake committed Jan 9, 2024
2 parents c2d04f1 + e5b9ee0 commit f921d94
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion src/test/fuzz/connman.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,10 @@ FUZZ_TARGET(connman, .init = initialize_connman)
*g_setup->m_node.netgroupman,
Params(),
fuzzed_data_provider.ConsumeBool()};

const uint64_t max_outbound_limit{fuzzed_data_provider.ConsumeIntegral<uint64_t>()};
connman.Init({ .nMaxOutboundLimit = max_outbound_limit });

CNetAddr random_netaddr;
CNode random_node = ConsumeNode(fuzzed_data_provider);
CSubNet random_subnet;
Expand Down Expand Up @@ -125,7 +129,7 @@ FUZZ_TARGET(connman, .init = initialize_connman)
(void)connman.GetAddedNodeInfo(fuzzed_data_provider.ConsumeBool());
(void)connman.GetExtraFullOutboundCount();
(void)connman.GetLocalServices();
(void)connman.GetMaxOutboundTarget();
assert(connman.GetMaxOutboundTarget() == max_outbound_limit);
(void)connman.GetMaxOutboundTimeframe();
(void)connman.GetMaxOutboundTimeLeftInCycle();
(void)connman.GetNetworkActive();
Expand Down

0 comments on commit f921d94

Please sign in to comment.