Added Ios target

[dodikk]

Added iOS library target.
Fixed memory management issues.

[natikgadzhi]

Thanks for the request.

And huge thanks for using / patching this. Since i wrote the original XNMaths a couple of years ago for an assignation project without any experience in Mac OS X apps development, it might have lots of non-optimal code, memory mgmt issues and so on.

I've noticed you added an iOS build target and removed cocoa requirements. That' great. But you've also added uikit requirement. Why do you need UIKit if you actually are not using any of UI components? Could we make it work with just foundation / coregraphics?

[dodikk]

1. UIKit is for CGRect, CGPoint and other stuff like this.
   My colleagues did not have enough time to bother with searching for the correct header. Sorry.
2. Yes. Your calloc() and unbalanced retain/release calls look suspicious.
   If you still maintain the library please consider using std::vector instead of C-style arrays. And consider adopting ARC for better Objective-C memory management.

[dodikk]

P.S. we've included UIKit for the same reason you've included Cocoa. ;)

[dodikk]

UIKit is required for [ NSValue CGPointValue ] on iOS.
In your case it all was covered by "#import Cocoa/Cocoa.h".
Since it's required, I've moved it to the *.pch files

[dodikk]

Fixed some CubicalSpline related leaks.

[dodikk]

Are you actually going to merge my changes to your own repo?

[natikgadzhi]

I don't like the idea of just switching Cocoa to UIKit in master branch. I'd have some time to review the code and adopt better memory mgmt practices, thanks for the concern, but i'd rather have special branch for with the same lib, UIKit included.

If i'll have enough time — i'll just cherry-pick classes we use there from Foundation / etc to not include neither Cocoa nor UIKit.

Нат
[email protected]
+7 (915) 359-27-55

On Monday, 14 May 2012 г. at 18:54, Oleksandr Dodatko wrote:

Are you actually going to merge my changes to your own repo?

---

Reply to this email directly or view it on GitHub:
#1 (comment)

[dodikk]

More memory leak fixes.
[WARNING] C++ code involved [WARNING]