Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.1 support #11

Open
stevie-mayhew opened this issue Nov 18, 2014 · 3 comments
Open

3.1 support #11

stevie-mayhew opened this issue Nov 18, 2014 · 3 comments

Comments

@stevie-mayhew
Copy link

There is already the great work of @timsnadden here https://github.com/timsnadden/silverstripe-customhtmleditorfield

Do you think you would be able to cherry pick that across to this repo? I've also emailed @timsnadden in case he can generate a PR 😄

@timsnadden
Copy link
Contributor

I've create a pull request for using yaml config #12

That being said, I believe that this repo should work in Silverstripe 3.1 as it stands. The differences from my fork are just whitespace and fixes to comment typos (apart from the changes in #12).

@nathancox
Copy link
Owner

Yeah it does work on 3.1 as-is but apparently I need to get better at remembering to tidy my code before I put it on Github. Anyway I accepted the pull request. Thanks for the interest everyone.

@stevie-mayhew
Copy link
Author

Cheers @nathancox and @timsnadden - excellent stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants