-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Adding DHS to PandExo, including front end #89
Open
natashabatalha
wants to merge
13
commits into
dev
Choose a base branch
from
dhs
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
3765228
fixes #79
natashabatalha b1ea989
first attempt with DHS
natashabatalha 8bb67e2
Merge pull request #88 from natashabatalha/dev
natashabatalha 4cd46e9
change default nircam read out patterns to shallow2, per nestor recs
natashabatalha cbf3b98
change naming formalism from nsample skip to ndrop2 which I think is …
natashabatalha b53dc9e
fix circle plots to step
natashabatalha 59982b6
add nircam DHS options to front end
natashabatalha 8eeaf18
front end working DHS
natashabatalha cb8ef1e
changes max ngroups for each instrument to accomodate 30 group max fo…
natashabatalha c380b68
add num spectra to output and also fix the aperture selection based o…
natashabatalha a960101
display ETC and APT name on the output page
natashabatalha ba94c83
change shallow2 to rapid
natashabatalha 2d17507
change from fml default to slope method
natashabatalha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
{ | ||
"telescope":"jwst", | ||
"scene":[ { | ||
"id": 1, | ||
"target": true, | ||
"position": { | ||
"ang_unit": "arcsec", | ||
"x_offset": 0.0, | ||
"y_offset": 0.0 | ||
}, | ||
"shape": { | ||
"geometry": "point" | ||
}, | ||
"spectrum": { | ||
"extinction": { | ||
"bandpass": "j", | ||
"law": "mw_rv_31", | ||
"unit": "mag", | ||
"value": 0.0 | ||
}, | ||
"normalization": { | ||
"type": "none"}, | ||
"sed": { | ||
"sed_type": "input", | ||
"spectrum": [] | ||
}, | ||
"lines": [] | ||
} | ||
}], | ||
|
||
"background_level": "medium", | ||
"background":"ecliptic", | ||
"calculation":{ | ||
"effects": { | ||
"background": true, | ||
"ipc": true, | ||
"saturation": true | ||
}, | ||
"noise": { | ||
"crs": true, | ||
"darkcurrent": true, | ||
"ffnoise": false, | ||
"readnoise": true, | ||
"rn_correlation": true | ||
} | ||
}, | ||
"configuration":{ | ||
"instrument": { | ||
"instrument": "nircam", | ||
"mode": "sw_tsgrism", | ||
"filter": "f150w2", | ||
"aperture": "dhs0spec8", | ||
"disperser": "dhs0" | ||
}, | ||
"detector": { | ||
"readout_pattern":"shallow2", | ||
"subarray": "sub256stripe4_dhs", | ||
"ngroup": "optimize", | ||
"nint": 1, | ||
"nexp": 10 | ||
} | ||
}, | ||
"strategy": { | ||
"method": "specapphot", | ||
"background_subtraction":true, | ||
"aperture_size": 0.7, | ||
"sky_annulus": [0.8,1.6], | ||
"target_xy": [0.0, 0.0], | ||
"reference_wavelength":null, | ||
"units":"arcsec" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change
shallow2
torapid
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed