-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUMULUS-3580 Use the correct variable for lzards launchpad secret value #3574
base: master
Are you sure you want to change the base?
Conversation
I resolved the CL merge conflict and waiting on the new build to pass. Otherwise this looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently launchpad token is cached in s3 https://github.com/nasa/cumulus/blob/v18.2.0/packages/launchpad-auth/src/LaunchpadToken.ts. More changes are needed if we cache more than one token. Also, we need to have a separate token service account to verify the change.
@jennyhliu nods that's a good point, this code has evolved, and there's a caching assumption. I'll update the ticket with this commentary, but at a minimum we'd need to update I'm not sure I agree we have to have another token service account - we can configure the same TSA with seperate cache files and that with units should cover this case sufficiently. |
Summary: Summary of changes
Addresses CUMULUS-3580
Changes
lzards_launchpad_passphrase
which was getting the value fromvar.launchpad_passphrase
instead ofvar.lzards_launchpad_passphrase
.PR Checklist