Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BulkRNASeq] V&V program mistypes samplenames as ints when possible #33

Open
J-81 opened this issue Jun 28, 2023 · 0 comments
Open

[BulkRNASeq] V&V program mistypes samplenames as ints when possible #33

J-81 opened this issue Jun 28, 2023 · 0 comments

Comments

@J-81
Copy link
Contributor

J-81 commented Jun 28, 2023

Description

When sample names can be interpreted as numerical instead of string (e.g. 12), certain V&V checks incorrectly do so result in failure to match '1' and 1.

Approaches

Samplename column should also be read in as datatype string.

Implementation Suggested

All runsheet loading should use a standard interface that interprets samplename as string datatype.

Validation Plan

GLDS-201 triggers the error and can serve to as a good test case.

Impact

No impact on prior data since error causes a false workflow halt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant