Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding count rate in core #127

Closed
wants to merge 10 commits into from
Closed

Adding count rate in core #127

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ec26409
adding count rate in core
Vidushi-GitHub Mar 1, 2024
ad0b083
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 1, 2024
eaf57f1
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 1, 2024
4049419
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 12, 2024
c12ffc1
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 12, 2024
1188604
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 12, 2024
35d0aff
Update gcn/notices/core/Statistics.schema.json
Vidushi-GitHub Mar 12, 2024
9119fdc
count rate and trigger type
Vidushi-GitHub Mar 13, 2024
e84f4da
count rate after rebase with new trig type property
Vidushi-GitHub Mar 14, 2024
821ec5b
count and trigger type
Vidushi-GitHub Mar 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gcn/notices/core/Statistics.example.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
{
"$schema": "https://gcn.nasa.gov/schema/main/gcn/notices/core/Statistics.schema.json",
"far": 0.001,
"net_count_rate": 2000,
"background_count_rate": 250,
"rate_snr": 5.2,
"rate_duration": 10,
"rate_energy_range": [100, 1000],
Expand Down
8 changes: 8 additions & 0 deletions gcn/notices/core/Statistics.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,14 @@
"type": "number",
"description": "False alarm rate: the rate of occurrence of non-astrophysical events that are of the same intensity or significance as the current event [Hz]"
},
"net_count_rate": {
"type": "number",
"description": "Net count rate of the transient above the background [counts/s]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description should specify that this is over the rate_duration and rate_energy_range.

Vidushi-GitHub marked this conversation as resolved.
Show resolved Hide resolved
},
"backgound_count_rate": {
"type": "number",
"description": "Count rate of the background for the transient [counts/s]"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment about rate_duration and rate_energy_range as in the net_count_rate.

Vidushi-GitHub marked this conversation as resolved.
Show resolved Hide resolved
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think we need to include this.

"rate_snr": {
"type": "number",
"description": "Rate signal to noise ratio [dimensionless]"
Expand Down