LVC Text Conversion #21
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
October 23, 2024 18:26
removed utils.py small fix updated trigger_date parsing and calet jsons creation editted conversion.py to deal with inputs that have no 'additional' dictionary Fixed ra/dec parsing to be seperate Updated alexis conversion updated poetry updated all modules for search_string
updated general parsing function to deal with empty strings LVC conversion deals with all notice types Added $schema field
updated README
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LVC Text Conversion is slightly different from the rest. Since the fields in the text notices seem to change for every other notice and I couldn't figure out any underlying pattern from looking through the text notices manually, I elected to just check if each keyword is in the notice and then add it according.