AMON Text conversion #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 23, 2024 16:06
removed utils.py small fix updated trigger_date parsing and calet jsons creation editted conversion.py to deal with inputs that have no 'additional' dictionary Fixed ra/dec parsing to be seperate Updated alexis conversion updated poetry updated all modules for search_string Added \n to additional_info in snews and sk_sn added all current conversions to main.py updated id changed url to lightcurve_url; added field Added field to all conversions
fixed ra_dec_error and ra_dec_error_50 removed comments
| - `far` → FAR | ||
|
|
||
| ### Defines the following new fields for the text notice fields | ||
| - `notice_type` → NOTICE_TYPE |
There was a problem hiding this comment.
NOTICE_TYPE is quiet common in GCN classic, it makes sense to add in core schema itself.
| - `coincidence_with` → COINC_PAIR | ||
|
|
||
| ## Caveats | ||
| - The notices have a field called STREAM, but these seems to be degenrate with NOTICE_TYPE and so I've not added these to the JSONs |
There was a problem hiding this comment.
Suggested change
| - The notices have a field called STREAM, but these seems to be degenrate with NOTICE_TYPE and so I've not added these to the JSONs | |
| - The notices have a field called STREAM, but these seems to be degenerate with NOTICE_TYPE and so I've not added these to the JSONs |
|
|
||
| ## Caveats | ||
| - The notices have a field called STREAM, but these seems to be degenrate with NOTICE_TYPE and so I've not added these to the JSONs | ||
| - SKYMAP_FITS_URL is a field for the Burst notice but these are not available for any of the notices. Hence, I've not included them in the JSONs |
There was a problem hiding this comment.
|
|
||
| return output | ||
|
|
||
|
|
There was a problem hiding this comment.
You can try: Python's standard library xml / html parser modules
Vidushi-GitHub
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AMON has multiple notices in multiple webpages which this conversion handles. I've added the following keywords not in the core schema.