Configure plugin for calling Search API #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpsinger
requested changes
Nov 21, 2023
ronitagarwala01
force-pushed
the
nlp_config
branch
2 times, most recently
from
7439adc to
be574d8
Compare
lpsinger
requested changes
Nov 27, 2023
There was a problem hiding this comment.
Why not just use https://www.npmjs.com/package/@nasa-gcn/architect-functions-search?
|
You mean import the client configured by architect-functions-search? I haven't tried that yet. Let me see if it works. |
Yes, exactly. If the service discovery is working, then architect-functions-search should work too. |
|
You were right. It works! |
lpsinger
requested changes
Nov 28, 2023
ronitagarwala01
force-pushed
the
nlp_config
branch
2 times, most recently
from
dbc8d6d to
c10538c
Compare
|
Please rebase. |
ronitagarwala01
force-pushed
the
nlp_config
branch
2 times, most recently
from
cbc84f8 to
f5e59c1
Compare
ronitagarwala01
changed the title
|
Done. |
lpsinger
requested changes
Dec 5, 2023
ronitagarwala01
changed the title
ronitagarwala01
force-pushed
the
nlp_config
branch
from
0efc3c3 to
1493ea1
Compare
|
Updated README.md |
ronitagarwala01
force-pushed
the
nlp_config
branch
from
1493ea1 to
7010a6b
Compare
lpsinger
requested changes
Dec 9, 2023
Execute post-deployment API requests in both sandbox mode and production. Add @nasa-gcn/architect-functions-search as dependency.
ronitagarwala01
force-pushed
the
nlp_config
branch
from
4aabbea to
9e18b21
Compare
lpsinger
requested changes
Dec 12, 2023
Co-authored-by: Leo Singer <[email protected]>
Co-authored-by: Leo Singer <[email protected]>
lpsinger
approved these changes
Dec 12, 2023
|
I know right? It makes it a little confusing imo, but there doesn't seem to be a work around. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add function to call a post-deployment search API file defined in gcn.nasa.gov. Allow for execution of REST API calls in both sandbox and production environments.