Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing datetime64[ms] type mapping #45

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dacopan
Copy link

@dacopan dacopan commented Apr 22, 2024

fix #44

@kenho811
Copy link

Hi @dacopan , and maintainers,

image

I am coming from the fork here

https://github.com/lenoyjacob/sqlalchemy_dremio

I raised the issue in dremio (see: https://community.dremio.com/t/superset-dremio-error-datetime64-ms-for-timestamp-field/11827)

I got the suggestion to try out that fork, and it solved my issue of the Superset connection to Dremio for timestamp date type (which is datetime64[ms])

============

While this PR looks a bit different from the fork, I believe the main point is really just to add the mapping (https://github.com/narendrans/sqlalchemy_dremio/pull/45/files#diff-9deefcdbf269b1ac22873d58d61153c381ee4bb71719eff7f8404d0ebddcaf76R32)

For now, I am using the fork in my superset docker image.

Is there any chance that this PR could get merged?

Thank you

@chenym250
Copy link

Just to chime in, this issue appears for me when pandas version is ~2.0.3; downgrading pandas to 1.5.3 fixed the issue for me. FWIW, I agree that adding datetime64[ms] to the dict is the best approach here.

@cmdel
Copy link

cmdel commented Aug 19, 2024

I'd also like to see this merged if it solves this issue. I' tried the lennoyjacob fork but I'm getting a 'BadGateway' error instead.
Any chance you can add it to a milestone?
Thnx

@ohappykust
Copy link

Hi, @narendrans! Is there a chance this fix will make it into the master branch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 'datetime64[ms]': types.DATETIME to _type_map in query.py
6 participants