Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PPF hypercube #389

Open
wants to merge 13 commits into
base: dev
Choose a base branch
from
Open

PPF hypercube #389

wants to merge 13 commits into from

Conversation

astrolamb
Copy link

I forgot to make a PR of my fixes to PR #366.

I'm adding a method to the PTA object to compute the PPF of a parameter sampled from a unit hypercube. This allows the user to easily use enterprise PTA objects in nested samplers.

There is also a unit test for the method.

Copy link
Member

@vhaasteren vhaasteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me

@vhaasteren
Copy link
Member

Hi @astrolamb , there are two files that have changes related to twine secrets and bumping the version. That should not be included in a PR like this one. Can you remove those?

Copy link
Member

@vhaasteren vhaasteren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strip out unrelated changes

.github/workflows/ci_test.yml Outdated Show resolved Hide resolved
setup.cfg Outdated Show resolved Hide resolved
Reverting accidental changes
Reverting accidental changes
@astrolamb
Copy link
Author

Apologies @vhaasteren, I'm not sure why those edit were in there. I've reverted those changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants