doc: add notes on httptest.ResponseRecorder

nanmu42 · Sep 18, 2021 · 4c35c5d · 4c35c5d
1 parent 2feb5f4
commit 4c35c5d
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/writerwrapper_test.go b/writerwrapper_test.go
@@ -397,4 +397,12 @@ func Test_writeWrapper_does_not_change_status_code_after_204(t *testing.T) {
 	_, _ = wrapper.Write([]byte("something"))
 
 	assert.Equal(t, http.StatusNoContent, recorder.Code)
-}
+	// httptest.ResponseRecorder does not deny Write when status code is 204 or 304.
+	// 	n, err := wrapper.Write([]byte("something"))
+	// 	assert.Equal(t, 0, n)
+	//	assert.Error(t, err)
+	//	assert.Equal(t, http.StatusNoContent, recorder.Code)
+	//	assert.Equal(t, []byte{}, recorder.Body.Bytes())
+	//
+	// ref: https://github.com/nanmu42/gzip/pull/5
+}