fix/max-length and max-length-enforcement on shad-input

nank1ro · Nov 18, 2024 · 6aa98fb · 6aa98fb
1 parent 8ab50f0
commit 6aa98fb
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,7 +1,7 @@
 ## 0.16.0
 
 - **FEAT**: New `ShadTimePicker` and `ShadDatePickerFormField` components.
-
+- **FIX**: `maxLength` and `maxLengthEnforcement` not working on `ShadInput`
 - **CHORE**: Set minimum Flutter version to `3.24.0`
 - **CHORE**: Remove `trackColor` from `ShadSwitch` (thanks to @RaghavTheGreat)
 

diff --git a/lib/src/components/input.dart b/lib/src/components/input.dart
@@ -408,6 +408,19 @@ class ShadInputState extends State<ShadInput>
           );
         };
 
+    final effectiveMaxLengthEnforcement = widget.maxLengthEnforcement ??
+        LengthLimitingTextInputFormatter.getDefaultMaxLengthEnforcement(
+            Theme.of(context).platform);
+
+    final effectiveInputFormatters = <TextInputFormatter>[
+      ...?widget.inputFormatters,
+      if (widget.maxLength != null)
+        LengthLimitingTextInputFormatter(
+          widget.maxLength,
+          maxLengthEnforcement: effectiveMaxLengthEnforcement,
+        ),
+    ];
+
     return ShadDisabled(
       disabled: !widget.enabled,
       child: _selectionGestureDetectorBuilder.buildGestureDetector(
@@ -512,7 +525,8 @@ class ShadInputState extends State<ShadInput>
                                         onSubmitted: widget.onSubmitted,
                                         onAppPrivateCommand:
                                             widget.onAppPrivateCommand,
-                                        inputFormatters: widget.inputFormatters,
+                                        inputFormatters:
+                                            effectiveInputFormatters,
                                         cursorWidth: widget.cursorWidth,
                                         cursorHeight: widget.cursorHeight,
                                         cursorRadius: widget.cursorRadius,