-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: implement repository-wide unit tests #73
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brech1
force-pushed
the
test/add-unit-tests
branch
from
June 15, 2024 00:12
016c20f
to
8e4f47e
Compare
brech1
force-pushed
the
test/add-unit-tests
branch
from
June 15, 2024 00:36
0054be2
to
6dff2f6
Compare
Codecov ReportAttention: Patch coverage is ❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
|
brech1
force-pushed
the
test/add-unit-tests
branch
from
June 17, 2024 13:52
0fb8fa9
to
a4d3865
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements unit testing for several modules. The majority of methods that didn't required a circuit mock were covered. Modules like
runtime
andcompiler
are almost entirely tested.The untested methods could be tested through integration tests, or through some testing utils with mocks in a future PR.
The workflow actions have been updated to include a testing coverage report.
There has also been some codebase structure updates.
Two bugs have been fixed:
Declaration of constant signals in the
compiler
moduleThe order of
value.is_some()
andfalse
was switched. This was declaring every constant signal as an output signal, and not setting it as constant.Signal substitution (found by @voltrevo)
If a signal was assigned to a value using a
Call
,PrefixOp
orNumber
this was being ignored, so these values have been added to substitution case match. The program errorSignalSubstitutionNotImplemented
has also been implemented.Changes
codecov
report in CI../vscode
settings.bin
config incargo.toml
../input/circuit.circom
.examples
folder and put those circuits in thetest
directory.ml-tests
folder and put those circuits in thetest
directory.IndexOutOfBounds
integration test @curryrasul.Related Issues