Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CLI #65

Merged
merged 9 commits into from
Jun 8, 2024
Merged

Refactor CLI #65

merged 9 commits into from
Jun 8, 2024

Conversation

curryrasul
Copy link
Collaborator

@curryrasul curryrasul commented May 31, 2024

Description

The PR aimes to remove unnecessary circom's code for CLI; update it for the current needs with a newer clap crate version

Issue

This PR aimed to close #52

@curryrasul curryrasul self-assigned this May 31, 2024
@curryrasul curryrasul marked this pull request as draft May 31, 2024 11:38
@curryrasul curryrasul marked this pull request as ready for review June 6, 2024 11:08
@curryrasul curryrasul requested review from brech1 and namnc June 6, 2024 11:14
@curryrasul curryrasul added this to the Release 0.1 milestone Jun 6, 2024
src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@brech1 brech1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@curryrasul
Copy link
Collaborator Author

@voltrevo Could you review this as well please? Because I was resolving merge conflict with your changes on main. I might have missed something ...

@voltrevo voltrevo merged commit fae6fb0 into main Jun 8, 2024
1 check passed
@voltrevo voltrevo deleted the issue-52-update-cli branch June 8, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add default project config and enable CLI configuration
3 participants