Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add events field to support handling multiple events per one command #23

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add events field to support handling multiple events per one command #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions chief_of_state/v1/writeside.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,9 +38,14 @@ message HandleCommandRequest {

// HandleCommandResponse
message HandleCommandResponse {
// An event to append to the journal. If not set, COS
// will treat this command as a no-op.
google.protobuf.Any event = 1;
// An event to append to the journal.
// This field is deprecated, please use events instead
google.protobuf.Any event = 1 [deprecated = true];
// Events to append to the journal.
repeated google.protobuf.Any events = 2;
// 1. If both event and events fields are not set, COS will treat this command as a no-op.
// 2. If both event and events fields are set, the event field will be disregarded.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ido-namely update this

// 3. Else, the event or events will be processed.
}

// HandleEventRequest
Expand Down