Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document Qt form sharing with Namecoin Core #384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Document Qt form sharing with Namecoin Core #384

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions electrum_nmc/electrum/gui/qt/forms/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
# Shared Namecoin Core / Electrum-NMC Qt GUI

Upstream Bitcoin Core and Electrum both use Qt for their GUI. Therefore, to minimize duplicated Namecoin-specific GUI code, Namecoin Core and Electrum-NMC share their Qt GUI form files. This requires an extra build step in Electrum-NMC (handled by the `contrib/make_qt_forms` script), since upstream Electrum does not use form files.

There are some differences between the Namecoin Core and Electrum-NMC versions of the form files. They are mostly due to:

1. Some features are implemented in Namecoin Core but not Electrum-NMC, or vice versa.
2. Electrum-NMC includes shim implementations of the Bitcoin Core widgets `QPayToEdit` and `QValidatedLineEdit`.

Pull requests to decrease the diff size would probably be welcome.

If you're copying changes in the form files between Namecoin Core and Electrum-NMC, and you get confusing errors that mention any of the Bitcoin Core widgets mentioned above, it is likely that you accidentally changed the references to the shims.