Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Poll, Vote, Admin Model #26

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

skartik-sk
Copy link
Contributor

Added Different Model for poll vote and Admin #11

@thefuadeniola
Copy link
Contributor

@skartik-sk Nice models you've got there. For the vote model, it would be better if the type was a boolean and not a string. I assume you can only possibly upvote and downvote. This is also a quick commit you can make before your pr is merged!!

@skartik-sk skartik-sk marked this pull request as draft October 3, 2024 14:10
@skartik-sk skartik-sk marked this pull request as ready for review October 3, 2024 14:13
@skartik-sk
Copy link
Contributor Author

Done Changes!
Is their anything else which is to be modified.

@thefuadeniola
Copy link
Contributor

All good!

@namansharma3007 namansharma3007 added enhancement New feature or request hacktoberfest Part of Open Source Contribution Event hacktoberfest-accepted Part of Open Source Contribution Event: 2024 labels Oct 3, 2024
@namansharma3007 namansharma3007 merged commit 83f0d99 into namansharma3007:main Oct 3, 2024
@namansharma3007
Copy link
Owner

@thefuadeniola Great Job

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest Part of Open Source Contribution Event hacktoberfest-accepted Part of Open Source Contribution Event: 2024
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants