Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager correct adaptation #121

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

TomchyshenDenys
Copy link

@TomchyshenDenys TomchyshenDenys commented Nov 2, 2021

Issues resolved for Xcode 13:

  1. Resolved warning related to missing resource according to the path Source/PhotoSlider.xcassets, but it was located at Source/PhotoSlider/PhotoSlider.xcassets
  2. Changed the way of fetching Kingsfisher dependency from SSH to HTTPS. As not every dev has set up ssh configuration to GitHub therefor it's good practice to use HTTPS that ain't constrained developers

nakajijapan and others added 2 commits November 2, 2021 11:58
…Resolved a warning by moving package asset to the Source root. Changed the way of fetching Kingsfisher dependency through https instead of ssh as it's not best practice
@TomchyshenDenys TomchyshenDenys changed the title Swift Package Manager correct adoption Swift Package Manager correct adaptation Nov 2, 2021
@a7ex
Copy link

a7ex commented Nov 22, 2021

It would be great, if this PR could be merged soon. Please... :-)

@TomchyshenDenys
Copy link
Author

@nakajijapan Good day! Sorry for so many commits, SPM works not really great with forks and it was difficult to fix it through fork
Could you please review and merge it? It relates only to Swift Package

@a7ex
Copy link

a7ex commented Nov 28, 2021

@nakajijapan Good day! Sorry for so many commits, SPM works not really great with forks and it was difficult to fix it through fork
Could you please review and merge it? It relates only to Swift Package

I tried indeed as well by forking the repo and found out, that it is hard to impossible to make it work for target platform <iOS 13, therefore you can count me out of people waiting for this change ;-)
It is the last library which prevents me from getting rid of cocoapods altogether, but now I will simply replace the whole thing by my own code. What it was used for in the app I am working on, is so trivial, that it is not worth any more hassle for me :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants