Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix v3 compatibilities #34

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Fix v3 compatibilities #34

wants to merge 8 commits into from

Conversation

zsu
Copy link

@zsu zsu commented Apr 9, 2022

Changes to fix v3 compatibilities. 'override' is renamed to 'overrideExisting' since override is a function in v3.

@seanhamlin
Copy link

Actual lifesaver. This PR works great.

@m08pvv
Copy link

m08pvv commented Sep 13, 2022

When this PR will be merged? It would be awesome to have it in the npm package

@igorlukanin
Copy link

@nagix Any chance you can take a look at this one, merge, and release it? I'd like to mention it as a Chart.js v3-compatible, working one in Chart.js docs on colors: chartjs/Chart.js#10764 (comment)

@homestar9
Copy link

@zsu excellent work with the fixes for V3!
@m08pvv, I appreciate you pushing up your NPM package! I mentioned it in the Issues area here to help others find it:
#38

FYI, I'm sure you both already know, but the fixes for V3 don't work with V4 for some reason. I tried to take a stab at it, but I can't figure out why the plugin won't register globally. I don't see any breaking changes that would cause it to cease working.

@MaximBelov
Copy link

MaximBelov commented Oct 15, 2024

Compatibility chart.js v3-v4

https://www.npmjs.com/package/hw-chartjs-plugin-colorschemes

#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants