-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix v3 compatibilities #34
base: master
Are you sure you want to change the base?
Conversation
Actual lifesaver. This PR works great. |
When this PR will be merged? It would be awesome to have it in the npm package |
@nagix Any chance you can take a look at this one, merge, and release it? I'd like to mention it as a Chart.js v3-compatible, working one in Chart.js docs on colors: chartjs/Chart.js#10764 (comment) |
@zsu excellent work with the fixes for V3! FYI, I'm sure you both already know, but the fixes for V3 don't work with V4 for some reason. I tried to take a stab at it, but I can't figure out why the plugin won't register globally. I don't see any breaking changes that would cause it to cease working. |
Compatibility chart.js v3-v4 https://www.npmjs.com/package/hw-chartjs-plugin-colorschemes |
Changes to fix v3 compatibilities. 'override' is renamed to 'overrideExisting' since override is a function in v3.