Code Review #1
Code Review #1
Conversation
| background-color: #f3f3f3; | ||
| } | ||
|
|
||
| #info{ |
| @@ -0,0 +1,215 @@ | |||
| @import url('https://fonts.googleapis.com/css?family=Courgette|Roboto'); | |||
There was a problem hiding this comment.
Use link instead of import to enable parallel downloads.
| border:0; | ||
| padding-left: 5px; | ||
| border-radius:3px 0 0 3px; | ||
| outline:none; |
There was a problem hiding this comment.
Outlines should only be modified using :focus.
| margin-left:10px; | ||
| } | ||
|
|
||
| section h2{ |
There was a problem hiding this comment.
Heading (h2) should not be qualified.
| } | ||
|
|
||
| function showUsersTable(){ | ||
| httpRequest = new XMLHttpRequest(); |
There was a problem hiding this comment.
Add the "let", "const" or "var" keyword to this declaration of "httpRequest" to make it explicit.
| thead.appendChild(trHead); | ||
| } | ||
|
|
||
| var tr = document.createElement("tr"); |
There was a problem hiding this comment.
Rename "tr" as this name is already used in declaration at line 89.
| tr.appendChild(tdNome); | ||
| tr.appendChild(tdEmail); | ||
| tr.dataset.id = data[i].id; | ||
| tr.onclick = function(){ |
There was a problem hiding this comment.
Define this function outside of a loop.
| } | ||
| } | ||
|
|
||
| function mountTablePublication(data){ |
There was a problem hiding this comment.
This function has very similar construct as mountTableUsers and many duplicated lines, consider refactoring both into a base function.
| } | ||
|
|
||
| function objectToHTML(data, property){ | ||
| for(a in data){ |
There was a problem hiding this comment.
Add the "let", "const" or "var" keyword to this declaration of "a" to make it explicit.
| <body> | ||
| <header class="flex"> | ||
| <figure class="logo flex vCenter center row"> | ||
| <img src="./img/logo.svg"> |
There was a problem hiding this comment.
Add an "alt" attribute to all images.
|
Regarding the layout, the information area does not follow the mockup.
|
No description provided.