-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(editor): Persist user's preferred display modes on localsStorage #11929
Open
netroy
wants to merge
1
commit into
master
Choose a base branch
from
persist-preferred-display-modes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
changed the title
deat(editor): Persist user's preferred display modes on localsStorage
feat(editor): Persist user's preferred display modes on localsStorage
Nov 27, 2024
n8n-assistant
bot
added
n8n team
Authored by the n8n team
ui
Enhancement in /editor-ui or /design-system
labels
Nov 27, 2024
netroy
force-pushed
the
persist-preferred-display-modes
branch
from
November 27, 2024 14:02
5ed4b47
to
f688931
Compare
netroy
force-pushed
the
persist-preferred-display-modes
branch
from
November 27, 2024 14:30
f688931
to
2dd23c7
Compare
cstuncsik
approved these changes
Nov 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates ndv store to persist user's preferred input/output displayMode to storage, so that app reloads don't switch NDV back to the schema view.
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)