Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(editor): Persist user's preferred display modes on localsStorage #11929

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 27, 2024

Summary

This PR updates ndv store to persist user's preferred input/output displayMode to storage, so that app reloads don't switch NDV back to the schema view.

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@netroy netroy changed the title deat(editor): Persist user's preferred display modes on localsStorage feat(editor): Persist user's preferred display modes on localsStorage Nov 27, 2024
@n8n-assistant n8n-assistant bot added n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system labels Nov 27, 2024
@netroy netroy force-pushed the persist-preferred-display-modes branch from 5ed4b47 to f688931 Compare November 27, 2024 14:02
@netroy netroy force-pushed the persist-preferred-display-modes branch from f688931 to 2dd23c7 Compare November 27, 2024 14:30
@netroy netroy marked this pull request as ready for review November 27, 2024 14:35
Copy link

codecov bot commented Nov 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link

cypress bot commented Nov 27, 2024

n8n    Run #8132

Run Properties:  status check failed Failed #8132  •  git commit 2dd23c7b9f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Project n8n
Branch Review persist-preferred-display-modes
Run status status check failed Failed #8132
Run duration 08m 17s
Commit git commit 2dd23c7b9f: 🌳 🖥️ browsers:node18.12.0-chrome107 🤖 netroy 🗃️ e2e/*
Committer कारतोफ्फेलस्क्रिप्ट™
View all properties for this run ↗︎

Test results
Tests that failed  Failures 14
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 385
View all changes introduced in this branch ↗︎

Tests for review

Failed  5-ndv.cy.ts • 6 failed tests

View Output Video

Test Artifacts
NDV > should disconect Switch outputs if rules order was changed Screenshots Video
NDV > Should render xml and html tags as strings and can search Screenshots Video
NDV > should keep search expanded after Test step node run Screenshots Video
NDV > test output schema view > should switch to output schema view and validate it Screenshots Video
NDV > test output schema view > should not display pagination for schema Screenshots Video
NDV > test output schema view > should display large schema Screenshots Video
Failed  13-pinning.cy.ts • 4 failed tests

View Output Video

Test Artifacts
Data pinning > Should be able to pin node output Test Replay Screenshots Video
Data pinning > Should be able to set pinned data Test Replay Screenshots Video
Data pinning > Should be duplicating pin data when duplicating node Test Replay Screenshots Video
Data pinning > should use pin data in manual executions that are started by a webhook Test Replay Screenshots Video
Failed  30-langchain.cy.ts • 1 failed test

View Output Video

Test Artifacts
Langchain Integration > should not show tool info notice if tools were used during execution Test Replay Screenshots Video
Failed  14-mapping.cy.ts • 1 failed test

View Output Video

Test Artifacts
Data mapping > maps expressions from table json, and resolves value based on hover Test Replay Screenshots Video
Failed  14-data-transformation-expressions.cy.ts • 2 failed tests

View Output Video

Test Artifacts
Data transformation expressions > $json + native array access Test Replay Screenshots Video
Data transformation expressions > $json + n8n array methods Test Replay Screenshots Video

The first 5 failed specs are shown, see all 36 specs in Cypress Cloud.

Flakiness  e2e/19-execution.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Execution > connections should be colored differently for pinned data > when executing a node Test Replay Screenshots Video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team ui Enhancement in /editor-ui or /design-system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants