Added missing 4 bits representing PUS version number in TC/TM secondary headers. #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcorg
reviewed
Mar 17, 2023
| @@ -45,7 +45,7 @@ TC-PacketDataField <INTEGER:secondaryHeaderFlag> [] | |||
| TC-DataWithSecondaryHeader [] | |||
| { | |||
| secondaryHeader [] { | |||
| tcPacketPusVersionNumber [], | |||
| tcPacketPusVersionNumber NULL [pattern '0010'B], | |||
There was a problem hiding this comment.
we should either use or delete PacketVersionNumber structure.
https://github.com/n7space/asn1-pusc-lib/blob/master/ccsds/PacketTypes.asn1#L38
I have a feeling, that it was supposed to go here but something was not working... hence the strange NULL in ASN.1...
There was a problem hiding this comment.
LOL, it has bad version: https://github.com/n7space/asn1-pusc-lib/blob/master/ccsds/PacketTypes.acn#L26
:D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.