Clarify comment about KtQ speed #31
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VDavid003
referenced
this pull request
in VDavid003/sm64-port-android
Aug 13, 2020
Merged. Thanks for your contribution! "Changed amount of sleep frames when transitioning from main menu and exiting a stage to fix TAS sync issues."
MaikelChan
pushed a commit
to MaikelChan/sm64
that referenced
this pull request
Oct 19, 2020
DbpGaming
pushed a commit
to DbpGaming/sm64
that referenced
this pull request
Nov 15, 2021
Puppycam Incline Look Smoothing
mountainflaw
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Chatted about this in #help in the discord about a week ago)
The original comment confused me when I was examining KtQ code, because it doesn't matter if Mario finishes the race fairly or finishes the race by cheating, only that he has finishes the race. This is what the code is checking for (oKoopaRaceEndpointRaceStatus!=0 matches both "Mario cheated" and "Mario didn't cheat").
I removed the part about the cannon, since it's implied by finishing the race, and added a line of English to help explain the rest of the conditional