refactor(iroh-relay): simplify structure in clients #3100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3100/docs/iroh/ Last updated: 2025-01-07T10:47:41Z |
matheus23
reviewed
Jan 7, 2025
Comment on lines
+111
to
+112
| drop(client); // avoid deadlock | ||
| self.unregister(dst).await; |
There was a problem hiding this comment.
Perhaps self.unregister should take the client: Ref<...>?
There was a problem hiding this comment.
to drop it in there? that seems uneccessary
There was a problem hiding this comment.
I like this suggestion, that could make it less dangerous?
There was a problem hiding this comment.
agreed that having unregister take the client we are doing something programatically to prevent this from happening again during a future refactor.
flub
reviewed
Jan 7, 2025
Comment on lines
+111
to
+112
| drop(client); // avoid deadlock | ||
| self.unregister(dst).await; |
There was a problem hiding this comment.
I like this suggestion, that could make it less dangerous?
matheus23
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Changes
Notes & open questions
Change checklist