refactor(iroh, iroh-relay): JoinSet disabling in tokio::select! #3052
+9
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the disabling of JoinSet::join_next branches in tokio::select! calls to rely on pattern matching alone. This changes nothing to the logic executing in the select! call, but often results in less code. A branch is disabled if the pattern does not match, and the remaining futures are still awaited. Once the branch is disabled the logic of tokio::select! is exactly the same regardless of whether it was disabled because of an if condition or because of a mismatched pattern.
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3052/docs/iroh/ Last updated: 2024-12-16T11:34:34Z |
dignifiedquire
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changes the disabling of JoinSet::join_next branches in
tokio::select! calls to rely on pattern matching alone. This changes
nothing to the logic executing in the select! call, but often results
in less code.
A branch is disabled if the pattern does not match, and the remaining
futures are still awaited. Once the branch is disabled the logic of
tokio::select! is exactly the same regardless of whether it was
disabled because of an if condition or because of a mismatched pattern.
Breaking Changes
Notes & open questions
Change checklist