New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(iroh-base)!: reduce dependencies #3046

Open

dignifiedquire wants to merge 2 commits into main from refactor-simplify-deps-base

+179 −441

Contributor

dignifiedquire commented Dec 13, 2024 •

edited

Loading

Description

ensure zeroize is used for SecretKey
remove unused dependencies and features from iroh-base

Breaking Changes

iroh_base::SecretKey::generate now takes an rng
removed iroh_base::SecretKey::generate_with_rng, use generate directly
removed iroh_base::SecretKey::to_openssh
removed iroh_base::SecretKey::from_openssh
anyhow::Error is replaced with explicit errors for RelayUrl::from_str
anyhow::Error is replaced with explicit errors for SharedSecret::open

Notes & open questions

As a follow up, all usage of SecretKey::generate in tests should be changed to use a seeded rng, like chacha8, instead of thread_rng

Change checklist

Self-review.
Documentation updates following the style guide, if relevant.
Tests if relevant.
All breaking changes documented.


          refactor(iroh-base)!: reduce dependencies

dignifiedquire requested a review from rklaehn

December 13, 2024 18:07

github-actions bot commented Dec 13, 2024 •

edited

Loading

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3046/docs/iroh/

Last updated: 2024-12-13T18:11:36Z


          typos

35e6232

dignifiedquire requested review from a team and removed request for rklaehn

December 13, 2024 18:10

github-actions bot commented Dec 13, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: c76679c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet