Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Make PUBLIC_KEY_LENGTH a const that is on PublicKey #3043

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

rklaehn
Copy link
Contributor

@rklaehn rklaehn commented Dec 13, 2024

Description

Make PUBLIC_KEY_LENGTH a const that is on PublicKey

that way it is not so in your face

Breaking Changes

  • PUBLIC_KEY_LENGTH is moved from a top level constant to PublicKey::LENGTH

that way it is not so in your face
@rklaehn rklaehn changed the title refactor: Make PUBLIC_KEY_LENGTH a const that is on PublicKey refactor!: Make PUBLIC_KEY_LENGTH a const that is on PublicKey Dec 13, 2024
Copy link

github-actions bot commented Dec 13, 2024

Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3043/docs/iroh/

Last updated: 2024-12-13T16:37:11Z

Copy link
Contributor

@divagant-martian divagant-martian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

personally very much in favor of this

Copy link

github-actions bot commented Dec 13, 2024

Netsim report & logs for this PR have been generated and is available at: LOGS
This report will remain available for 3 days.

Last updated for commit: 477e36b

@rklaehn rklaehn enabled auto-merge December 13, 2024 16:38
@rklaehn rklaehn added this pull request to the merge queue Dec 13, 2024
Merged via the queue into main with commit 218aad3 Dec 13, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants