refactor(iroh-base)!: remove hash and BlobTicket #3036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3036/docs/iroh/ Last updated: 2024-12-12T12:29:33Z |
dignifiedquire
changed the title
dignifiedquire
force-pushed
the
refactor-remove-hash
branch
from
437e165 to
acc8d3e
Compare
rklaehn
approved these changes
Dec 12, 2024
| @@ -65,6 +62,7 @@ key = [ | |||
| "dep:derive_more", | |||
| "dep:getrandom", | |||
| "base32", | |||
| "relay", | |||
There was a problem hiding this comment.
yeah, that was a fix I noticed when testing this change
| mod node; | ||
|
|
||
| pub use self::{blob::BlobTicket, node::NodeTicket}; | ||
| pub use self::node::NodeTicket; |
There was a problem hiding this comment.
We could also move NodeTicket to iroh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These have been moved to
iroh-blobsn0-computer/iroh-blobs#38Breaking Changes
iroh_base::ticket::BlobTicket->iroh_blobs::ticket::BlobTicketiroh_base::Hash->iroh_blobs::Hashiroh_base::HashAndFormat->iroh_blobs::HashAndFormatiroh_base::BlobFormat->iroh_blobs::BlobFormatNotes & open questions
Change checklist