refactor(iroh): rename ConnectedRelayActor to ActiveRelayActor #3027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation for this PR has been generated and is available at: https://n0-computer.github.io/iroh/pr/3027/docs/iroh/ Last updated: 2024-12-12T13:45:37Z |
dignifiedquire
approved these changes
Dec 10, 2024
flub
force-pushed
the
flub/active-relay-again
branch
from
840abb5 to
e29b41b
Compare
Yes, that's (almost) back to what it was called... The name has grown on me and it is better because the relay is not always connected. This does also fit better with what it should be doing: keep the connection alive if possible. Currently this functionality is mixed up in the RelayActor itself.
flub
force-pushed
the
flub/active-relay-again
branch
from
e29b41b to
2ec4263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Yes, that's (almost) back to what it was called...
The name has grown on me and it is better because the relay is not always connected. This does also fit better with what it should be doing: keep the connection alive if possible. Currently this functionality is mixed up in the RelayActor itself.
Breaking Changes
Notes & open questions
flub/relay-send-channel-1, be aware of github when merging things.Change checklist